Skip to content

PIMS-2364 Net Book - Allow 0 #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2025
Merged

PIMS-2364 Net Book - Allow 0 #3036

merged 3 commits into from
Nov 5, 2025

Conversation

@dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Aug 11, 2025

🎯 Summary

PIMS-2364

Changes

  • Allow for 0 as valid net book value on projects as per PO.
  • Change formatMoney function to display the cents if available.

Testing

Try to add/edit a project and have the Net Book field have a 0.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Aug 11, 2025
@github-actions github-actions bot added the React label Aug 11, 2025
@github-actions
Copy link

github-actions bot commented Aug 11, 2025

🚀 Deployment Information

The React APP Image has been built with the tag: 3036. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

@Sharala-Perumal
Copy link
Collaborator

Sharala-Perumal commented Oct 30, 2025

On testing, its evident that Net book value is accepting $0 as a valid entry as shown below:
image
image
However, its not accepting blank values for Net book value as shown below. Is that acceptable? If so, I can progress the ticket to Approved. Plz confirm.
image

@dbarkowsky
Copy link
Collaborator Author

dbarkowsky commented Nov 3, 2025

However, its not accepting blank values for Net book value as shown below. Is that acceptable? If so, I can progress the ticket to Approved. Plz confirm.

I believe this is the intended behaviour. It encourages the field to be user-entered, so they don't just skip it. It is still required they enter something, it's just that 0 is now an acceptable value.

@dbarkowsky dbarkowsky merged commit 52adf37 into main Nov 5, 2025
9 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-2364 branch November 5, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sharala-Perumal Sharala-Perumal Sharala-Perumal approved these changes

@LawrenceLau2020 LawrenceLau2020 Awaiting requested review from LawrenceLau2020 LawrenceLau2020 is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

@dbarkowsky dbarkowsky

Labels

React

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbarkowsky @Sharala-Perumal